Files
kulakpos_web/walkthroughs/2026-05-14_b817429e_Walkthrough__Fixing_PostgreSQL_Compatibility.md

38 lines
2.6 KiB
Markdown
Raw Permalink Normal View History

2026-05-14 12:25:21 +07:00
# Fix: BadMethodCallException & PostgreSQL Compatibility Audit
2026-05-14 11:55:22 +07:00
2026-05-14 12:25:21 +07:00
I have resolved the `BadMethodCallException` reported in the `AcnooSaleController` and performed a final "automated" audit to fix remaining PostgreSQL compatibility issues.
2026-05-14 11:55:22 +07:00
## Changes Made
2026-05-14 12:25:21 +07:00
### 1. Fixed Missing `dueForBranch` Method
- **File**: [Party.php](file:///media/itc43/Data/OTHER_PROJECT/kulakpos/kulakpos_15Maret2026_to%20GTEA/public_html/app/Models/Party.php)
- **Fix**: Implemented the `dueForBranch($branchId = null)` method in the `Party` model.
- **Logic**:
- For **Suppliers**: Sums `dueAmount` from the `purchases` table for the specified branch.
- For **Customers**: Sums `dueAmount` from the `sales` table for the specified branch.
- This resolves the crash on the Sale and Purchase creation screens.
### 2. Automated PostgreSQL Audit & Fixes
I ran an audit script to find remaining MySQL-specific syntax or unquoted mixed-case identifiers.
- **[AcnooBranchController.php](file:///media/itc43/Data/OTHER_PROJECT/kulakpos/kulakpos_15Maret2026_to%20GTEA/public_html/Modules/MultiBranchAddon/App/Http/Controllers/AcnooBranchController.php)**: Quoted `"lossProfit"` in `incomeExpense` reports.
- **[Admin/DashboardController.php](file:///media/itc43/Data/OTHER_PROJECT/kulakpos/kulakpos_15Maret2026_to%20GTEA/public_html/app/Http/Controllers/Admin/DashboardController.php)**:
- Updated `TO_CHAR` format to `FMMonth` to avoid padded spaces.
- Fixed `groupBy` to use the full expression instead of an alias for better PostgreSQL compatibility.
- **[StatisticsController.php](file:///media/itc43/Data/OTHER_PROJECT/kulakpos/kulakpos_15Maret2026_to%20GTEA/public_html/app/Http/Controllers/Api/StatisticsController.php)**:
- Updated `groupBy` logic to use the `TO_CHAR` expression directly, preventing "must appear in the GROUP BY clause" errors.
## Verification
### Automated Audit
- The audit script was used to identify these locations.
- You can find the script here: [audit_postgres.py](file:///media/itc43/Data/OTHER_PROJECT/kulakpos/kulakpos_15Maret2026_to%20GTEA/public_html/scratch/audit_postgres.py).
### Manual Verification Required
1. **Sale Creation**: Open the "Create Sale" screen to verify that customer due amounts are now displayed correctly without error.
2. **Purchase Creation**: Open the "Create Purchase" screen to verify supplier due amounts.
3. **Reports**: Check the Branch Income/Expense report and Admin Dashboard to ensure charts are rendering correctly.
> [!NOTE]
> I have committed these changes locally. Please run `git push` from your terminal to upload the fixes to your repository.